Yes, the S trap is illegal and needs to be changed like Geoff said. If the smell was due to the S trap you'd have the smell above the sink not in the cabinet
In California an apprentice can run calls on the first day if he's working for someone with a contractor's license. Obviously it's not a good idea but I believe it's legal.